All tests implemented. Formatt, lint & typecheck

tests/test_node_deployer.py

@@ -1,5 +1,6 @@
 import atexit
 import filecmp
+import os
 from pathlib import Path
 import pickle
 import shutil
@@ -9,25 +10,47 @@ import tomllib
 
 
 config.update_config("test")
-config.BUILD_DIR = config.BUILD_DIR / "tests"
-atexit.register(lambda: shutil.rmtree(config.BUILD_DIR, ignore_errors=True))
+config.BUILD_DIR = config.BUILD_DIR / f"tests/{os.getpid()}"
 
-from node_deployer import autoignition, create_img  # noqa: E402
+
+def remove_pid_build_dir():
+    shutil.rmtree(config.BUILD_DIR, ignore_errors=True)
+
+
+def remove_test_build_dir():
+    test_build_dir = config.BUILD_DIR.parent
+    if any(test_build_dir.iterdir()):
+        try:
+            test_build_dir.rmdir()
+        except OSError:
+            pass
+
+
+def cleanup():
+    remove_pid_build_dir()
+    remove_test_build_dir()
+
+
+atexit.register(cleanup)
+
+from node_deployer import autoignition, create_disk, create_img  # noqa: E402
 
 
 with open(config.PROJECT_ROOT / "tests/data/node_deployer/test_args.toml", "rb") as f:
     TEST_PARAMS = tomllib.load(f)
 
+TEST_DATA_DIR = config.PROJECT_ROOT / "tests/data/node_deployer"
+
 
 class TestAutoignition:
     def test_json_to_img(self, tmp_path: Path):
         tmp_path.mkdir(parents=True, exist_ok=True)
         autoignition.json_to_img(
-            config.PROJECT_ROOT / "tests/data/node_deployer/fuelignition.json",
+            TEST_DATA_DIR / "fuelignition.json",
             tmp_path / "ignition.img",
         )
         assert filecmp.cmp(
-            config.PROJECT_ROOT / "tests/data/node_deployer/ignition.img",
+            TEST_DATA_DIR / "ignition.img",
             tmp_path / "ignition.img",
         )
 
@@ -35,14 +58,12 @@ class TestAutoignition:
 class TestCreateImg:
     def test_load_template(self):
         template = create_img.load_template()
-        with open(
-            config.PROJECT_ROOT / "tests/data/node_deployer/create_img/load_template.pkl", "rb"
-        ) as f:
+        with open(TEST_DATA_DIR / "create_img/load_template.pkl", "rb") as f:
             assert pickle.load(f) == template
 
     def test_apply_ignition_settings(self):
         with open(
-            config.PROJECT_ROOT / "tests/data/node_deployer/create_img/load_template.pkl",
+            TEST_DATA_DIR / "create_img/load_template.pkl",
             mode="rb",
         ) as f:
             template = pickle.load(f)
@@ -51,7 +72,7 @@ class TestCreateImg:
             **TEST_PARAMS["create_img"]["apply_ignition_settings"],
         )
         with open(
-            config.PROJECT_ROOT / "tests/data/node_deployer/create_img/apply_ignition_settings.pkl",
+            TEST_DATA_DIR / "create_img/apply_ignition_settings.pkl",
             mode="rb",
         ) as f:
             expected = pickle.load(f)
@@ -66,23 +87,32 @@ class TestCreateImg:
         )
         assert filecmp.cmp(
             tmp_path / "ignition.img",
-            config.PROJECT_ROOT / "tests/data/node_deployer/ignition.img",
+            TEST_DATA_DIR / "ignition.img",
         )
 
 
-# class TestWriteDisk:
-#     def init(self):
-#         test_target = config.BUILD_DIR / "ignition.img"
-#         if not test_target.exists():
-#             test_target.write_bytes(
-#                 Path(config.PROJECT_ROOT / "tests/data/node_deployer/ignition.img").read_bytes()
-#             )
+class TestCreateDisk:
+    def init_buildfile(self, filename: str):
+        config.BUILD_DIR.mkdir(parents=True, exist_ok=True)
+        test_target = config.BUILD_DIR / filename
+        if not test_target.exists():
+            test_target.write_bytes(Path(TEST_DATA_DIR / filename).read_bytes())
 
-#     def test_validation_result(self):
-#         raise NotImplementedError
+    def test_filter_validation_response(self):
+        self.init_buildfile("config.ign")
+        with open(TEST_DATA_DIR / "create_disk/validation_result.pkl", "rb") as f:
+            input = pickle.load(f)
+        test_result = create_disk.filter_validation_response(input)
+        assert test_result == ""
 
-#     def test_filter_validation_result(self):
-#         raise NotImplementedError
+    def test_validation_result(self):
+        self.init_buildfile("config.ign")
+        test_result = create_disk.validation_result()
+        with open(TEST_DATA_DIR / "create_disk/validation_result.pkl", "rb") as f:
+            expected = pickle.load(f)
+        assert test_result == expected
 
-#     def test_validate(self):
-#         raise NotImplementedError
+    def test_validate(self):
+        self.init_buildfile("config.ign")
+        test_result = create_disk.validate()
+        assert test_result == (True, "")