release v0.12.5

CHANGES.rst

@@ -8,6 +8,11 @@
 Changes
 =======
 
+Version v0.12.5 (release 2024-07-29)
+
+- fix: permission for ip
+
+
 Version v0.12.3 (release 2024-07-25)
 
 - fix(tugraz_authenticated): missmatch of role name

invenio_config_tugraz/__init__.py

@@ -11,7 +11,7 @@
 from .ext import InvenioConfigTugraz
 from .utils import get_identity_from_user_by_email
 
-__version__ = "0.12.3"
+__version__ = "0.12.5"
 
 __all__ = (
     "__version__",

invenio_config_tugraz/permissions/generators.py

@@ -65,12 +65,11 @@ class RecordSingleIP(Generator):
         if record is None:
             return []
 
-        # if record does not have singleip - return any_user
-        if not record.get("custom_fields", {}).get("single_ip", False):
-            return [any_user]
-
         # if record has singleip, and the ip of the user matches the allowed ip
-        if self.check_permission():
+        if (
+            record.get("custom_fields", {}).get("single_ip", False)
+            and self.check_permission()
+        ):
             return [any_user]
 
         # non of the above - return empty
@@ -138,12 +137,11 @@ class AllowedFromIPNetwork(Generator):
         if record is None:
             return []
 
-        # if the record doesn't have set the ip range allowance
-        if not record.get("custom_fields", {}).get("ip_network", False):
-            return [any_user]
-
         # if the record has set the ip_range allowance and is in the range
-        if self.check_permission():
+        if (
+            record.get("custom_fields", {}).get("ip_network", False)
+            and self.check_permission()
+        ):
             return [any_user]
 
         # non of the above - return empty